<Swing Dev> RFR 8245921:Minor copy/paste issue in BasicScrollBarUI

[Prasanta Sadhukhan]

Hi All,

Please review a small fix for a minor copy/paste error in 
javax.swing.plaf.basic.BasicScrollBarUI.installDefaults()

if ("large".equals(scaleKey)){
                 scrollBarWidth *= 1.15;
                 incrGap *= 1.15;
                 decrGap *= 1.15;
             } else if ("small".equals(scaleKey)){
                 scrollBarWidth *= 0.857;
                 incrGap *= 0.857;
                 decrGap *= 0.714;
             } else if ("mini".equals(scaleKey)){
                 scrollBarWidth *= 0.714;
                 incrGap *= 0.714;
                 decrGap *= 0.714;
             }

In the "small" case, decrGap is multiplied by 0.714 instead of 0.857.

This code snippet has been added as part of the enhancement to support 
Nimbus L&F in JDK-6591875. 
<https://bugs.openjdk.java.net/browse/JDK-6591875>

In SynthScrollBarUI.java which is also added as part of above JBS, the 
correct value is used 
http://hg.openjdk.java.net/jdk/client/annotate/43e06bc950ec/jdk/src/share/classes/javax/swing/plaf/synth/SynthScrollBarUI.java#l116

Bug: https://bugs.openjdk.java.net/browse/JDK-8245921

diff -r b1bd79b486bc 
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java
--- 
a/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java 
Wed Jun 10 12:43:22 2020 +0530
+++ 
b/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java 
Thu Jun 25 12:57:37 2020 +0530
@@ -270,7 +270,7 @@
              } else if ("small".equals(scaleKey)){
                  scrollBarWidth *= 0.857;
                  incrGap *= 0.857;
-                decrGap *= 0.714;
+                decrGap *= 0.857;
              } else if ("mini".equals(scaleKey)){
                  scrollBarWidth *= 0.714;
                  incrGap *= 0.714;

Regards
Prasanta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200625/9d281acf/attachment.htm>