<Swing Dev> RFR: 8197560: test javax/swing/JTree/8003400/Test8003400.java fails

Pankaj Bansal pankaj.b.bansal at oracle.com
Tue Jun 30 07:33:02 UTC 2020


Hello Sergey,

<<The change looks fine, but please confirm that the test will fail on 
the build before JDK-8003400 was fixed

I have verified that the test is failing without the fix done for 
JDK-8003400

<<BTW the new bugid in the @bug tag is not necessary.

Ok, I will remove it before pushing the change.


Regards,

Pankaj

On 30/06/20 8:08 AM, Sergey Bylokhov wrote:
> The change looks fine, but please confirm that the test will fail on 
> the build before JDK-8003400 was fixed.
> BTW the new bugid in the @bug tag is not necessary.
>
> On 6/26/20 12:01 pm, Pankaj Bansal wrote:
>> Hi Sergey/Prasanta,
>>
>> I have made changes to the test to work on all platforms. I have also 
>> made changes to run it on all installed look and feels on the 
>> platforms. The test is passing on all L&Fs on all platforms. Link in 
>> the JBS.
>>
>> webrev: http://cr.openjdk.java.net/~pbansal/8197560/webrev01/ 
>> <http://cr.openjdk.java.net/%7Epbansal/8197560/webrev01/>
>>
>>
>> Regards,
>>
>> Pankaj
>>
>>
>> On 26/06/20 9:39 PM, Sergey Bylokhov wrote:
>>> On 6/25/20 9:27 pm, Prasanta Sadhukhan wrote:
>>>> sting only in windows, then probably we need to move the bugfix to 
>>>> WindowsTreeUI before changing the test to windows-only.
>>>
>>> I think that even if the fix could be moved to WindowsTreeUI, the 
>>> use case
>>> which caused the bug is not windows specific, and could potentially 
>>> exist
>>> on other L&F and platforms. SO it is better to update the test to 
>>> work on all
>>> platforms/L&Fs
>>>
>>
>
>



More information about the swing-dev mailing list