<Swing Dev> Remove System.out.println from ImageIcon.loadImage

Philip Race philip.race at oracle.com
Sun Mar 8 23:12:11 UTC 2020


I think you are reading too much into it.
The docs are just trying to say its synchronous and
you don't need need to use a MediaTracker yourself.

Retrying - even once - seems wrong.

-phil


On 1/21/20, 12:55 PM, Sergey Bylokhov wrote:
> On 1/21/20 12:26 pm, Jason Mehrens wrote:
>> +1 for Sergey suggestion.
>
> Or probably we need to try to load the image again because of the spec 
> of the method state this:
> "Loads the image, returning only when the image is loaded."
>
>>
>> ________________________________________
>> From: Sergey Bylokhov <Sergey.Bylokhov at oracle.com>
>> Sent: Sunday, January 19, 2020 9:31 PM
>> To: Volodin, Vladislav; Jason Mehrens
>> Cc: swing-dev at openjdk.java.net
>> Subject: Re: <Swing Dev> Remove System.out.println from 
>> ImageIcon.loadImage
>>
>> I guess there are no objections, probably the best way to fix
>> it is to drop the System.out.println and set interrupted flag.
>>
>> On 1/16/20 7:05 am, Volodin, Vladislav wrote:
>>> If people in this distribution list agree, I can start working on a 
>>> simple fix and either remove the logging (System.out.println), or 
>>> replace it with PlatformLogger. I guess the second solution sounds 
>>> better, but I don't know what is the better way to write a test-case 
>>> for it.
>>
>>
>> -- 
>> Best regards, Sergey.
>>
>
>


More information about the swing-dev mailing list