<Swing Dev> RFR: 8233584: [Win LAF] When navigating the contents of the file list changes in Win LAF

Pankaj Bansal pankaj.b.bansal at oracle.com
Mon Mar 9 10:48:52 UTC 2020


Hello Bhawesh,

The product change looks good.
As discussed in the internal review for moving the test to open from closed repo, please change the test name to a meaningful name and change the copyright year. Also, please follow max 80 characters per line convention.

Regards,
Pankaj

-----Original Message-----
From: Bhawesh Choudhary 
Sent: Wednesday, March 4, 2020 4:13 PM
To: swing-dev at openjdk.java.net
Subject: <Swing Dev> RFR: 8233584: [Win LAF] When navigating the contents of the file list changes in Win LAF

Hi,

Please review this fix,
JBS:         https://bugs.openjdk.java.net/browse/JDK-8233584
Webrev: http://cr.openjdk.java.net/~psadhukhan/8233584/webrev/

Issue:
In Windows LookAndFeel, When navigating Combobox's list of JFileChooser via keys, the contents of JFileChooser changes.

Fix:
Set flag "JComboBox.isTableCellEditor" to True which prohibits JCombobox from sending selection change event when JCombobox's list selection change happens via keys.


Verification:
Tested the fix with JFileChooser with WindowsLookAndFeelEnabled as well as BasicLookAndFeel with keys navigation. also added a test case to verify the same.

Did not find any misbehavior with the fix.

Regards
Bhawesh


More information about the swing-dev mailing list