<Swing Dev> RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Tejpal Rebari tejpal.rebari at oracle.com
Tue Mar 10 08:04:30 UTC 2020


Hi Sergey,

> On 09-Mar-2020, at 5:27 PM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> 
> Hi, Tejpal.
> Do not you need to call super.keySet() as well?
>  +set.addAll(super.keySet());
>   return set;

Yes, will update this.
> 
> similar to public Set<Entry<Object, Object>> entrySet() {...}
> 
> It would be good to update the test to cover this.
I am not getting how to cover this in the test.
Isn’t comparing the number of elements in the Enumeration and Set not enough.

Thanks
Tejpal


More information about the swing-dev mailing list