<Swing Dev> RFR: 8240633 Memory leaks in the implementations of FileChooserUI

[Prasanta Sadhukhan]

On 11-Mar-20 11:41 AM, Sergey Bylokhov wrote:
> On 3/10/20 11:00 pm, Prasanta Sadhukhan wrote:
>>
>> On 11-Mar-20 11:24 AM, Sergey Bylokhov wrote:
>>> On 3/10/20 10:23 pm, Prasanta Sadhukhan wrote:
>>>>>
>>>> Yes, it was part of MetalFileChooseUI and WindowsFileChooserUI too 
>>>> but it was removed explicitly in uninstallUI.
>>>
>>> The MetalFileChooseUI and WindowsFileChooserUI use non-local(we 
>>> could say public) listeners for example 
>>> BasicFileChooserUI.getCancelSelectionAction():
>>>
>>> These listeners could be accessed by the application since is a 
>>> BasicFileChooserUI is in the "javax.swing.plaf.basic" package.
>>> So we should not use these listeners after the L&F switch. The Aqua 
>>> uses only its own listeners, so they die at the same time as the 
>>> FileChooseUI itself.
>>>
>>>
>> OK. What about fileNameTextField. Shouldn't we need to uninstallUI 
>> that too?
>
> It does not have a jbutton inside so it not necessary, the problem 
> only exists for jbutton itself, or any compound components which use 
> jbutton inside.
>
>
OK. Thanks for the clarification. Looks fine to me.

Regards
Prasanta
>
>