<Swing Dev> RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Fri Mar 13 10:06:59 UTC 2020


Looks fine.

On 3/13/20 2:30 am, Tejpal Rebari wrote:
> Hi Sergey,
> 
>> On 11-Mar-2020, at 5:27 AM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>>
>> On 3/10/20 1:04 am, Tejpal Rebari wrote:
>>> I am not getting how to cover this in the test.
>>
>> I that additional call is necessary, then it should be possible to trigger it by the test.
>>
>> -- 
>> Best regards, Sergey.
> 
> I have updated the test to check for super.keySet().
> 
> Now the test will check for
> 1. defaults key size returned by the UIManager.getDefaults()
> 2. key size after writing an additional value to the UIManager.getDefaults()
> 
> Verified that the tests fails after the fix of http://cr.openjdk.java.net/~trebari/swing/8146330/webrev1/
> and passes after adding set.addAll(super.keySet());
> Updated webrev : http://cr.openjdk.java.net/~trebari/swing/8146330/webrev2/
> 
> Thanks
> Tejpal
> 


-- 
Best regards, Sergey.


More information about the swing-dev mailing list