<Swing Dev> RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

[Jayathirth D v]

+1.

Thanks,
Jay

> On 13-Mar-2020, at 4:31 PM, Tejpal Rebari <tejpal.rebari at oracle.com> wrote:
> 
> Hi Jay,
>> On 13-Mar-2020, at 3:55 PM, Jayathirth D v <JAYATHIRTH.D.V at ORACLE.COM <mailto:JAYATHIRTH.D.V at ORACLE.COM>> wrote:
>> 
>> Hi Tejpal,
>> 
>> Test case is not verifying all failure scenarios properly (If both test cases fail exception will be thrown only for first test failure)
>> Make sure that you verify each test case failure and print appropriate message.
>> 
>> Source change looks good to me.
>> 
>> Thanks,
>> Jay
>> 
> I have updated the test to properly print the error message according to test cases failure.
> Updated webrev : http://cr.openjdk.java.net/~trebari/swing/8146330/webrev3/ <http://cr.openjdk.java.net/~trebari/swing/8146330/webrev3/>
> 
> Thanks
> Tejpal
> 
> 
>>> On 13-Mar-2020, at 3:36 PM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>>> 
>>> Looks fine.
>>> 
>>> On 3/13/20 2:30 am, Tejpal Rebari wrote:
>>>> Hi Sergey,
>>>>> On 11-Mar-2020, at 5:27 AM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com><mailto:Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>>> wrote:
>>>>> 
>>>>> On 3/10/20 1:04 am, Tejpal Rebari wrote:
>>>>>> I am not getting how to cover this in the test.
>>>>> 
>>>>> I that additional call is necessary, then it should be possible to trigger it by the test.
>>>>> 
>>>>> -- 
>>>>> Best regards, Sergey.
>>>> I have updated the test to check for super.keySet().
>>>> Now the test will check for
>>>> 1. defaults key size returned by the UIManager.getDefaults()
>>>> 2. key size after writing an additional value to the UIManager.getDefaults()
>>>> Verified that the tests fails after the fix of http://cr.openjdk.java.net/~trebari/swing/8146330/webrev1/ <http://cr.openjdk.java.net/~trebari/swing/8146330/webrev1/>
>>>> and passes after adding set.addAll(super.keySet());
>>>> Updated webrev : http://cr.openjdk.java.net/~trebari/swing/8146330/webrev2/ <http://cr.openjdk.java.net/~trebari/swing/8146330/webrev2/>
>>>> Thanks
>>>> Tejpal
>>> 
>>> 
>>> -- 
>>> Best regards, Sergey.
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200313/d4be4b79/attachment.htm>