<Swing Dev> RFR JDK-8236635: JTabbedPane preferred size calculation is wrong for SCROLL_TAB_LAYOUT

[Pankaj Bansal]

Looks good to me

-Pankaj


On 13/03/20 10:09 PM, Prasanta Sadhukhan wrote:
>
> Hi All,
>
> Please review a fix for an issue where it is seen the frame height is 
> different in ubuntu19.10 when it contains JTabbedPane with 
> SCROLL_TAB_LAYOUT policy compared to WRAP_TAB_LAYOUT policy.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8236635
>
> Issue is because the native frame decorations are different in 19.10 
> compared to 18.04, where the issue is not seen. Fix is to set the 
> frame undecorated. The original issue 8215396 still fails with this 
> modified test without the 8215396 fix.
>
> diff -r 062b36ecf8d7 test/jdk/ProblemList.txt
>
> --- a/test/jdk/ProblemList.txt  Thu Feb 20 14:49:20 2020 +0530
> +++ b/test/jdk/ProblemList.txt  Fri Mar 13 21:56:05 2020 +0530
> @@ -822,7 +822,6 @@
>  javax/swing/JCheckBox/8032667/bug8032667_image_diff.java 8199063 
> macosx-all
>  javax/swing/JComboBox/7031551/bug7031551.java 8199056 generic-all
>  javax/swing/JScrollBar/6924059/bug6924059.java 8199078 generic-all
> *-javax/swing/JTabbedPane/TabProb.java 8236635 linux-all*
>  javax/swing/JTree/8003830/bug8003830.java 8199057 generic-all
>  javax/swing/plaf/nimbus/ColorCustomizationTest.java 8199080 generic-all
>  javax/swing/SwingWorker/6432565/bug6432565.java 8199077 generic-all
>
> diff -r 062b36ecf8d7 test/jdk/javax/swing/JTabbedPane/TabProb.java
>
> --- a/test/jdk/javax/swing/JTabbedPane/TabProb.java     Thu Feb 20 
> 14:49:20 2020 +0530
> +++ b/test/jdk/javax/swing/JTabbedPane/TabProb.java     Fri Mar 13 
> 21:56:05 2020 +0530
> @@ -82,6 +82,7 @@
>          panel.add(label);
>          tabpanel.add("TEST", panel);
>          add(tabpanel, BorderLayout.CENTER);
> *+        setUndecorated(true);*
>          setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);
>
>      }
> Regards
> Prasanta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200316/dfa53c3d/attachment.htm>