<Swing Dev> RFR 8241078: OOM error parsing HTML with large <pre> Tag text

Alexey Ivanov alexey.ivanov at oracle.com
Wed Mar 18 22:24:50 UTC 2020


Hi Prasanta,

Looks good to me too.

On 18/03/2020 21:59, Sergey Bylokhov wrote:
> Looks fine.
>
> On 3/17/20 8:54 pm, Prasanta Sadhukhan wrote:
>> Hi Sergey,
>>
>> Test updated
>>
>> http://cr.openjdk.java.net/~psadhukhan/8241078/webrev.1/
>>
>> Regards
>> Prasanta
>> On 17-Mar-20 11:48 PM, Sergey Bylokhov wrote:
>>> HI, Prasanta.
>>>
>>> I suggest to limit memory in the test by the "-mx", otherwise
>>> the test will pass on the systems which has the big amount of memory.
>>> I tested 100G, when it pass.
>>>
>>> On 3/17/20 6:54 am, Prasanta Sadhukhan wrote:
>>>> Hi All,
>>>>
>>>> Please review a fix for an issue where it is seen that OOM errors 
>>>> generated when parsing HTML files with large <pre> tagtext.
>>>>
>>>> This is because of fix done in JDK-8173123 where the entire data 
>>>> array was copied again and again, insteadof the range specified via 
>>>> offset.
>>>>
>>>> Fix is to use the offset in array copying to only copy the range 
>>>> specified
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8241078
>>>>
>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8241078/webrev.0/
>>>>
>>>> All javax/swing/text/html and javax/swing/text/DefaultStyleDocument 
>>>> jtreg test still pass after this change.
>>>>
>>>> Regards
>>>> Prasanta
-- 
Regards,
Alexey


More information about the swing-dev mailing list