<Swing Dev> RFR JDK-8240995:[macos] Unified toolbar is broken in JDK 11

[Sergey Bylokhov]

On 3/21/20 9:07 pm, Prasanta Sadhukhan wrote:
> And if you see the output after my fix, it is showing brushMetalLook output correctly,

But it is done via "TRANSPARENT_TITLE_BAR" and "FULL_WINDOW_CONTENT" properties
which are already implemented, not via "TEXTURED" property.


> 
> Also NSWindow.h that my 10.14.6 has does not say “textured background should no longer be used”. I am attaching the file
> 
> static const NSWindowStyleMask NSTexturedBackgroundWindowMask NS_DEPRECATED_WITH_REPLACEMENT_MAC("NSWindowStyleMaskTexturedBackground", 10.0, 10.12) = NSWindowStyleMaskTexturedBackground;
> 
> Regards
> Prasanta
> 
>> On 22-Mar-2020, at 4:17 AM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>>
>> Hi, Prasanta.
>>
>>> Issue is because of the fact that with migration to new SDK by JDK-8205424, the flags used to specify textured background for NSWindow is deprecated and we did not update the code with new flag.>> Fix is to use new flags as specified by apple doc
>> Are you sure that the new flag is a replacement of "NSTexturedBackgroundWindowMask"?
>> I think that this new flag is a replacement of "NSFullSizeContentViewWindowMask" which is
>> also used in the AWTWindow:
>>
>> 209         if (IS(styleBits, FULL_WINDOW_CONTENT))  type |= NSFullSizeContentViewWindowMask;
>>
>> I guess the old property "NSTexturedBackgroundWindowMask" should be replaced by the
>> "NSWindowStyleMaskTexturedBackground" but it is also deprecated since 10.14:
>>
>> ============================================
>> http://codeworkshop.net/objc-diff/sdkdiffs/macos/10.14/AppKit.html
>>
>> Modified NSWindowStyleMaskTexturedBackground
>> AvailabilityDeprecation Message
>> FromAvailablenone
>> ToDeprecatedTextured window style should no longer be used
>> ============================================
>>
>> So it looks like we already do our best, and should recommend everybody to not use the "Textured window style".
>>
>> -- 
>> Best regards, Sergey.
> 


-- 
Best regards, Sergey.