<Swing Dev> RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

[Philip Race]

I realise this thread has moved on to a more important topic but
I don't understand why it is "difficult" to get the os version

public class V {
public static void main(String[] args) {
  System.out.println(System.getProperty("os.version"));
  }
}

$ java V
10.13.6

On 3/23/20, 2:18 AM, Ajit Ghaisas wrote:
> OK.
> If we decide to add the check, this might help - 
> test/jdk/java/nio/file/etc/MacVolumesTest.java.
>
> Regards,
> Ajit
>
>> On 23-Mar-2020, at 1:04 PM, Prasanta Sadhukhan 
>> <prasanta.sadhukhan at oracle.com 
>> <mailto:prasanta.sadhukhan at oracle.com>> wrote:
>>
>> we at present do have easy way to test for osx version, unlike 
>> windows through OSInfo class. I will like to hear from Sergey if that 
>> is needed for this test (as he was the author) before trying to write 
>> such code myself.
>>
>> Regards
>> Prasanta
>> On 23-Mar-20 12:21 PM, Ajit Ghaisas wrote:
>>> Instead of ignoring it on all versions of osx, can we configure it 
>>> NOT to run on osx 10.14 onwards?
>>> *From:*Pankaj Bansal
>>> *Sent:*Monday, March 23, 2020 10:55 AM
>>> *To:*Prasanta 
>>> Sadhukhan<prasanta.sadhukhan at oracle.com>;swing-dev at openjdk.java.net
>>> *Subject:*Re: <Swing Dev> RFR JDK-8239312 [macos] 
>>> javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java
>>> Ok, looks good to me.
>>> -Pankaj
>>> *From:*Prasanta Sadhukhan
>>> *Sent:*Monday, March 23, 2020 10:54 AM
>>> *To:*Pankaj Bansal <pankaj.b.bansal at oracle.com 
>>> <mailto:pankaj.b.bansal at oracle.com>>;swing-dev at openjdk.java.net 
>>> <mailto:swing-dev at openjdk.java.net>
>>> *Subject:*Re: <Swing Dev> RFR JDK-8239312 [macos] 
>>> javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java
>>>
>>> I prefer it not to be deleted as we can still use it as standalone 
>>> mode for version lesser than 10.14 in case we need to test something 
>>> on those versions for textured JFrame.
>>>
>>> Regards
>>> Prasanta
>>> On 23-Mar-20 10:43 AM, Pankaj Bansal wrote:
>>>
>>>     Hello Prasanta,
>>>     If I am not wrong, now this test will be ignored on all versions
>>>     of osx and since it is only meant for Mac, basically this will
>>>     never be run after this change. Can’t we just delete the test?
>>>     Regards,
>>>     Pankaj
>>>     *From:*Prasanta Sadhukhan
>>>     *Sent:*Sunday, March 22, 2020 12:20 PM
>>>     *To:*swing-dev at openjdk.java.net <mailto:swing-dev at openjdk.java.net>
>>>     *Subject:*<Swing Dev> RFR JDK-8239312 [macos]
>>>     javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java
>>>     Hi All,
>>>     Since Textured JFrame property is not supported anymore by
>>>     Apple, the test which is failing from osx10.14 onwards should be
>>>     ignored from now onwards
>>>     diff -r 20374b37dd01
>>>     test/jdk/javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java
>>>     ---
>>>     a/test/jdk/javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.javaThu
>>>     Mar 19 22:22:39 2020 -0700
>>>     +++
>>>     b/test/jdk/javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.javaSun
>>>     Mar 22 12:17:37 2020 +0530
>>>     @@ -31,7 +31,7 @@
>>>      import jdk.test.lib.Platform;
>>>      /**
>>>     - * @test
>>>     + * @ignore
>>>     * @key headful
>>>     * @bug 7124513
>>>     * @requires (os.family == "mac”)
>>>
>>>
>>>
>>>     Regards
>>>     Prasanta
>>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200324/2b2d6231/attachment-0001.htm>