<Swing Dev> RFR JDK-8240995:[macos] Unified toolbar is broken in JDK 11

[Sergey Bylokhov]

On 3/21/20 11:29 pm, Prasanta Sadhukhan wrote:
> ok. I will close the bug as "Wont fix"

Note that these TRANSPARENT_TITLE_BAR and FULL_WINDOW_CONTENT are not
present in the jdk11/jdk8, so you probably need to backport some other
fixes.

> 
> On 22-Mar-20 11:53 AM, Sergey Bylokhov wrote:
>> On 3/21/20 10:31 pm, Prasanta Sadhukhan wrote:
>>>
>>> On 22-Mar-20 10:35 AM, Sergey Bylokhov wrote:
>>>> On 3/21/20 9:07 pm, Prasanta Sadhukhan wrote:
>>>>> And if you see the output after my fix, it is showing brushMetalLook output correctly,
>>>>
>>>> But it is done via "TRANSPARENT_TITLE_BAR" and "FULL_WINDOW_CONTENT" properties
>>>> which are already implemented, not via "TEXTURED" property.
>>>>
>>> Yes, but that is what was asked by the warning message to do for this support, no?
>>
>> All these properties are mapped directly to some native macOS styles.
>> As far as I understand the Apple deprecate the textured property(+it
>> stop working) and replaced it by something else, it means the apps
>> which use the old property should start to use the new one.
>>
>> Not sure that we should go beyond, and support something which is
>> unsupported by the Apple itself.
>>
>> and also the regression test is passing which is testing the textured frame after the fix!!
>>
>> The test was created to check how textured nswindow works, so it is
>> expected to fail since the props does not work. After the fix it will
>> check different properties which are checked by this test already:
>> jdk/java/awt/Window/FullWindowContentTest/FullWindowContentTest.java
>>


-- 
Best regards, Sergey.