<Swing Dev> RFR: 8233553 [TESTBUG] JSpinner test bug4973721.java fails on MacOS

Prasanta Sadhukhan prasanta.sadhukhan at oracle.com
Tue May 19 09:26:21 UTC 2020


looks ok to me. But you need to rectify code-formatting before pushing

88 try { listener.wait(5000); }
89 catch (InterruptedException e) {}
   90                 }
as try {
     } catch () {}


128 if (frame != null)
129 SwingUtilities.invokeAndWait(() -> frame.dispose());

Please add curly braces
if() {
.........
}

Regards
Prasanta
On 19-May-20 2:20 PM, Tejpal Rebari wrote:
> Hi All,
> Please review the following test only fix for jdk15.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8233553
> Webrev : http://cr.openjdk.java.net/~trebari/swing/8233553/webrev00/
>
> This test was added to problem list because it was failing
> in nightly testing.
>
> Now I  ran the test several time on internal build and test system
> both individually and in groups , and it is passing every time.
> Links are in JBS.
>
> Thanks
> Tejpal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200519/1a1837b3/attachment-0001.htm>


More information about the swing-dev mailing list