<Swing Dev> Minor copy/paste issue in BasicScrollBarUI ?

Vicne vicnevicne at gmail.com
Thu May 21 15:37:36 UTC 2020


Hi,

I came across the following code in 
javax.swing.plaf.basic.BasicScrollBarUI.installDefaults() :

            if ("large".equals(scaleKey)){
                 scrollBarWidth *= 1.15;
                 incrGap *= 1.15;
                 decrGap *= 1.15;
             } else if ("small".equals(scaleKey)){
                 scrollBarWidth *= 0.857;
                 incrGap *= 0.857;
*                decrGap *= 0.714;*
             } else if ("mini".equals(scaleKey)){
                 scrollBarWidth *= 0.714;
                 incrGap *= 0.714;
                 decrGap *= 0.714;
             }

There is no comment indicating a reason why decrGap is multiplied by 
0.714 - instead of 0.857 - in the second case, so I'd be tempted to 
think it's a copy/paste error...

What do you think ?

KR,


     Vicne
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200521/98253194/attachment.htm>


More information about the swing-dev mailing list