<Swing Dev> RFR 8245668:closed test javax/swing/JComboBox/4765319/bug4765319.java fails on windows

Prasanta Sadhukhan prasanta.sadhukhan at oracle.com
Sat May 23 12:11:37 UTC 2020


Hi All,

Please review a fix for an issue seen whereby VK_ENTER is not handled 
when popup is visible for a comboBox.

This issue is regressed because of the JDK-8067986 fix where a check is 
done upfront whether to accept this key VK_ENTER by checking if InputMap 
for VK_ENTER is set up or not.

The fix did not take into account if popup is visible or not. If popup 
is visible, it should irrespectively accept and allow actionPerformed() 
to be executed.

Fix is updated to check for popup visibility. The closed test and 
8067986 regression test both pass with this change.

Bug: https://bugs.openjdk.java.net/browse/JDK-8245668

webrev: http://cr.openjdk.java.net/~psadhukhan/8245668/webrev.0/

Regards
Prasanta


More information about the swing-dev mailing list