<Swing Dev> RFR: 8251177: [macosx] The text "big" is truncated [v2]

Pankaj Bansal pbansal at openjdk.java.net
Mon Nov 2 10:46:08 UTC 2020


> The manual test creates a JTabbedPane and add tabs with text with different html styles. For the tab with text "big", a bigger text size is used and it is expected that this should result in making the tab height bigger.
> 
> For AquaLookAndFeel, inside class AquaJTabbedPaneUI and AquaTabbedPaneCopyFromBasicUI, the tabs height is constraint and there is upper/lower limit set for tab height. So the tab height is less than expected and the text looks truncated. I do not see this issue in other L&Fs.
> 
> It looks like this is done deliberately for AquaL&F and this is not a bug. but the test instructions do not specify this and result in confusion. So updating the test instructions to specify that the text "big" may be truncated in MacOS.

Pankaj Bansal has updated the pull request incrementally with one additional commit since the last revision:

  Fixing review comments

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/984/files
  - new: https://git.openjdk.java.net/jdk/pull/984/files/e6e441e3..206a5db0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=984&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=984&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/984.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/984/head:pull/984

PR: https://git.openjdk.java.net/jdk/pull/984


More information about the swing-dev mailing list