<Swing Dev> RFR: 4907798: MEMORY LEAK: javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper [v2]

[Sergey Bylokhov]

On Mon, 9 Nov 2020 11:57:40 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java line 1229:
>> 
>>> 1227:                 // and uninstall menu keybindings
>>> 1228:                    removeItems();
>>> 1229:                    menuInputMap = null;
>> 
>> Just curious, will the uninstall(); at the start of the method will clear this flag as well?
>
> We do call ninstall() at the beginning of the method but it does not resolve the issue.

I meant this code at the start of the method:
`            if (!(UIManager.getLookAndFeel() instanceof BasicLookAndFeel)) {
                uninstall();
                return;
            }`
If "uninstall" will not solve the problem and the code added in this fix will not be executed, then we will get the same leak?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1035