<Swing Dev> RFR: 4916923: In MetalRootPaneUI, MetalRootLayout does not correctly calculate minimumsize

Sergey Bylokhov serb at openjdk.java.net
Fri Oct 2 22:17:38 UTC 2020


On Wed, 30 Sep 2020 12:11:38 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Please review a fix for an issue where minimumLayoutSize and preferredlayoutSize of MetalRootLayout class wrongly uses
> the width of the title pane in the height calculation: Proposed fix is to rectify the anomaly and use tpHeight for
> height calculation.
> All closed, open jtreg and JCK tests and SwingSet2 Metal L&F are unaffected by this change.

src/java.desktop/share/classes/javax/swing/plaf/metal/MetalRootPaneUI.java line 539:

> 537:
> 538:             return new Dimension(Math.max(Math.max(cpWidth, mbWidth), tpWidth) + i.left + i.right,
> 539:                                  cpHeight + mbHeight + tpHeight + i.top + i.bottom);

Is it possible to check this change by some testcase?

-------------

PR: https://git.openjdk.java.net/jdk/pull/433


More information about the swing-dev mailing list