<Swing Dev> RFR: 8251123: doclint warnings about missing javadoc tags and comments [v2]
Sergey Bylokhov
serb at openjdk.java.net
Sat Oct 3 00:31:48 UTC 2020
> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
>
> The fix:
> - Adds missing comments to the non-static/non-transient fields(even private) of the "serializable" classes
> - Adds comments to the "serializable" classes even if those classes are non-public
> - Fixes references/adds missing tags to the special methods(like readObject/writeObject)
> - Delete the java.awt.PeerFixer class.
>
> I need advice about what exact change should be reviewed in the CSR(except PeerFixer removal)
>
> Note that in some cases I added the comments to the "implementation details", so I did not specify it fully.
>
> The old review request:
> https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000423.html
Sergey Bylokhov has updated the pull request incrementally with two additional commits since the last revision:
- Update ScrollPane.java
- Update based on the feedback
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/369/files
- new: https://git.openjdk.java.net/jdk/pull/369/files/cfc1df5d..c1d83696
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=369&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=369&range=00-01
Stats: 52 lines in 3 files changed: 49 ins; 1 del; 2 mod
Patch: https://git.openjdk.java.net/jdk/pull/369.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/369/head:pull/369
PR: https://git.openjdk.java.net/jdk/pull/369
More information about the swing-dev
mailing list