<Swing Dev> RFR: 8028281: [TEST_BUG] [macosx] javax/swing/JTabbedPane/7024235/Test7024235.java fails

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Sun Oct 25 07:52:36 UTC 2020


On Sun, 25 Oct 2020 06:29:23 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> The test fails because of a missed null check for the next method:
>> https://docs.oracle.com/en/java/javase/15/docs/api/java.desktop/javax/swing/JTabbedPane.html#getBoundsAt(int)
>
> test/jdk/javax/swing/JTabbedPane/7024235/Test7024235.java line 108:
> 
>> 106:         for (int index = 0; index < this.pane.getTabCount(); index++) {
>> 107:             Rectangle bounds = this.pane.getBoundsAt(index);
>> 108:             if (bounds == null) {
> 
> The Aqua L&F uses scroll for the tabs so some of them may be invisible, and then null is returned as specified by the `getBoundsAt(index)`

Looks ok but it will be good to have a mach5 job listed in JBS testing this modified test on all platforms.

-------------

PR: https://git.openjdk.java.net/jdk/pull/852


More information about the swing-dev mailing list