<Swing Dev> RFR: 8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX [v2]
Sergey Bylokhov
serb at openjdk.java.net
Tue Oct 27 07:10:31 UTC 2020
> The test fails on macOS when Aqua L&F is enabled:
>> Test4 works well for all our LaFs because they set symmetrical insets for the JTextField, when Aqua sets 6 points for top/bottom and 7 for left/right which breaks the testing routine with the hardcoded values. The empty border should be set for the tested JTextField.
> https://bugs.openjdk.java.net/browse/JDK-7124209?focusedCommentId=12231936&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-12231936
>
> Mixed story of this bug.
>
> 1. Initially it was found by https://bugs.openjdk.java.net/browse/JDK-7124209
> but for some reason the change for that bug missed the actual fix and just moved the test to the open repo.
>
> 2. But it did not appear as failed because it was problemlisted by the
> https://bugs.openjdk.java.net/browse/JDK-8198399
> 3. Recently it was de-problemlisted by the
> https://bugs.openjdk.java.net/browse/JDK-8254976
> 4. But the check via mach5 missed this issue, becouse on the headless systems default L&F is Metal not Aqua.
Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
Update bug4726194.java
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/872/files
- new: https://git.openjdk.java.net/jdk/pull/872/files/281a5382..e839c7ea
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=872&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=872&range=00-01
Stats: 38 lines in 1 file changed: 19 ins; 3 del; 16 mod
Patch: https://git.openjdk.java.net/jdk/pull/872.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/872/head:pull/872
PR: https://git.openjdk.java.net/jdk/pull/872
More information about the swing-dev
mailing list