<Swing Dev> RFR: 8252721: Nested classes in Swing APIs rely on default constructors [v2]

[Phil Race]

On Wed, 9 Sep 2020 05:40:30 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Please review a fix for issue where it was seen that several
>> nested classes rely on default constructors as part of their public API.
>> 
>> It's to be noted that "A no-arg public constructor is generated by the compiler for a class if it does not declare an
>> explicit constructor. While convenient, this is inappropriate for many kinds of formal classes, both because the
>> constructor will have no javadoc and because the constructor may be unintended."  For the JDK, classes intended to be
>> used outside of the JDK, public classes in exported packages, should not rely on default constructors.
>> Proposed fix is to add explicit public no-arg constructors for public classes and protected no-arg constructor for
>> public abstract classes for javax.swing module (as one part of overalll java.desktop change)
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8252908
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Modify access modifier to protected for protected classes

Marked as reviewed by prr (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/72