<Swing Dev> RFR: 8252722: More Swing plaf APIs that rely on default constructors [v3]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Thu Sep 24 05:07:21 UTC 2020


On Mon, 21 Sep 2020 18:17:20 GMT, Phil Race <prr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboPopup.java line 737:
> 
>> 735:     protected class InvocationMouseHandler extends MouseAdapter {
>> 736:         /**
>> 737:          * Constructor for subclasses to call.
> 
> IMO this wording is not right here. This class is concrete isn't it ? So any code in this package can create one - not
> just a subclass.

it's outdated file you are reviewing..It's already changed yesterday.

-------------

PR: https://git.openjdk.java.net/jdk/pull/251


More information about the swing-dev mailing list