<Swing Dev> RFR: 8252194: Add automated test for fix done in JDK-8218469

[Pankaj Bansal]

Hi Alex,

Thanks for the review.

On 27/09/20 11:27 PM, Alexander Zuev wrote:
> Hi Pankaj,
>
>   in your test you have both
>   * @requires (os.family == "linux")
> and
>           if (!System.getProperty("os.name").startsWith("Linux")) {
>               System.out.println("This test is meant for Linux platform only");
>               return;
>           }
> Isn't it a little bit overkill?
>
This has been discussed earlier for some other test. The logic is that, 
if the test is run under jtreg, the test would not be run/scheduled at 
all due to @requires tag on non-linux platforms. If the test is run as 
standalone test, the test will start but the "if" condition should stop 
the test.

Regards,
Pankaj

> Otherwise looks good.
>
> /Alex
>
> On 9/27/2020 9:51 AM, Pankaj Bansal wrote:
>> Under JDK-8218469, fix was made to correct the rendering of JSlider as the Slider knob/head was not being rendered at
>> all. The reason was that gtk3 changed the way styles are used. No automated test was written to verify the results.
>> Current bug is to write the automated tests for the same. I have verified that the test fails without the fix done for
>> DK-8218469 and passes with the fix.
>>
>> -------------
>>
>> Commit messages:
>>   - Add automated test for fix done in JDK-8218469
>>
>> Changes:https://git.openjdk.java.net/jdk/pull/374/files
>>   Webrev:https://webrevs.openjdk.java.net/?repo=jdk&pr=374&range=00
>>    Issue:https://bugs.openjdk.java.net/browse/JDK-8252194
>>    Stats: 148 lines in 1 file changed: 148 ins; 0 del; 0 mod
>>    Patch:https://git.openjdk.java.net/jdk/pull/374.diff
>>    Fetch: git fetchhttps://git.openjdk.java.net/jdk  pull/374/head:pull/374
>>
>> PR:https://git.openjdk.java.net/jdk/pull/374
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200928/baa0bda6/attachment.htm>