<Swing Dev> RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v3]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Thu Apr 1 16:12:42 UTC 2021


On Thu, 1 Apr 2021 15:50:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javadoc change
>
> src/java.desktop/share/classes/javax/swing/JMenu.java line 1260:
> 
>> 1258:     /**
>> 1259:      * Sets the orientation for this menu and the associated popup component
>> 1260:      * determined by the <code>ComponentOrientation</code> argument.
> 
> Suggestion:
> 
>      * determined by the {@code ComponentOrientation} argument.
> The new code should use javadoc syntax.

I did not change it as then we may need to change `applyComponentOrientation` which uses the same syntax. It will look odd having different syntax in same file.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3213


More information about the swing-dev mailing list