<Swing Dev> RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

[Jonathan Gibbons]

On Wed, 7 Apr 2021 20:34:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> I dont see any update in JDK-8264217. Is this then considered to be a javadoc bug? 
>> 
>> It does not matter is it a JavaDoc bug or feature. If it is a bug it will be fixed and spec will be returned for the current method. If it is an intentional feature to skip the identical comments in the subclasses then the spec in the current method will be intentionally skipped.
>
>> > I dont see any update in JDK-8264217. Is this then considered to be a javadoc bug?
>> 
>> It does not matter is it a JavaDoc bug or feature. If it is a bug it will be fixed and spec will be returned for the current method. If it is an intentional feature to skip the identical comments in the subclasses then the spec in the current method will be intentionally skipped.
> 
> Then this bug is not an issue, right?
> 
> Unless we want to document that `JMenu.setComponentOrientation` _also sets_ the orientation to _`popupMenu`_, which doesn't change the orientation of menu items the `popupMenu` contains. However, it aligns with the specification: use `applyComponentOrientation` to change the orientation of the components contained within.

The behavior is not a javadoc bug.

If a method is overridden with no specified change in behavior, the 
method will be documented in the "Methods Declared In ..." list at the 
end of the main summary table.

-- Jon

On 4/7/21 1:07 PM, Sergey Bylokhov wrote:
>
>     I dont see any update in JDK-8264217. Is this then considered to
>     be a javadoc bug?
>
> It does not matter is it a JavaDoc bug or feature. If it is a bug it 
> will be fixed and spec will be returned for the current method. If it 
> is an intentional feature to skip the identical comments in the 
> subclasses then the spec in the current method will be intentionally 
> skipped.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub 
> <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/3213*issuecomment-815211518__;Iw!!GqivPVa7Brio!Pa32I0dQ97f0ZnfS2GJagqLEL_rDDUn_-KYlfMpVlhPTSTuZMR8dX8JS11YTkpCKIqVxAQ$>, 
> or unsubscribe 
> <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOUXBRUWEZO3Y5GPQXJXSDTTHS3ORANCNFSM4Z3HDOJA__;!!GqivPVa7Brio!Pa32I0dQ97f0ZnfS2GJagqLEL_rDDUn_-KYlfMpVlhPTSTuZMR8dX8JS11YTkpAt6XZ-PQ$>.
>

-------------

PR: https://git.openjdk.java.net/jdk/pull/3213