<Swing Dev> RFR: 8264398: BevelBorderUIResource​(int, Color, Color) spec should mention that the passed colors are for highlightInner and shadowOuter props

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Thu Apr 8 04:40:04 UTC 2021


On Thu, 8 Apr 2021 04:27:02 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Not sure I understand...The change is still in BevelorderUIResource(int, Color, Color) method so what should be changed in PR title?
>
>> Not sure I understand...The change is still in BevelorderUIResource(int, Color, Color) method so what should be changed in PR title?
> 
> It should be Bevelorder as well, the class from where the spec is copied to the BevelorderUIResource.

I don't think the spec is coped from BevelBorder...Yes, the spec is inspired by how BevelBorder treates the shadow/highlight color!!
You want same spec to be copied to BevelBorder(int, Color, Color) constrcutor too?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3305


More information about the swing-dev mailing list