<Swing Dev> RFR: 8264398: BevelBorderUIResource(int, Color, Color) and BevelBoder(int, Color, Color) spec should clarify about usage of highlight and shadow color [v3]

Sat Apr 10 02:59:19 UTC 2021

On Fri, 9 Apr 2021 00:44:54 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javadoc change in BevelBorder constructor
>
> src/java.desktop/share/classes/javax/swing/border/BevelBorder.java line 89:
> 
>> 87:      * Creates a bevel border with the specified type, highlight and
>> 88:      * shadow colors.
>> 89:      * highlightOuterColor and highlightInnerColor will be derived from
> 
> I think we should use just a brief text for "highlightOuterColor"/etc like in the other parts of class "the outer shadow"/"the inner shadow"/"the inner highlight" etc.  Since in this particular case the highlightOuterColor is not a parameter nor a field.
> And please update the copyright dates.

I guess I have done what is being asked. Are there any other comments? If not, can this PR and CSR be approved please?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3305

<Swing Dev> RFR: 8264398: BevelBorderUIResource​(int, Color, Color) and BevelBoder(int, Color, Color) spec should clarify about usage of highlight and shadow color [v3]

<Swing Dev> RFR: 8264398: BevelBorderUIResource(int, Color, Color) and BevelBoder(int, Color, Color) spec should clarify about usage of highlight and shadow color [v3]