<Swing Dev> RFR: 8264398: BevelBorderUIResource​(int, Color, Color) and BevelBoder(int, Color, Color) spec should clarify about usage of highlight and shadow color [v5]

Sergey Bylokhov serb at openjdk.java.net
Sat Apr 10 20:34:32 UTC 2021


On Fri, 9 Apr 2021 03:20:43 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> The current spec for javax/swing/plaf/BorderUIResource.BevelBorderUIResource.html(int,java.awt.Color,java.awt.Color) does not clearly specify the usage of color for hightlight and shadow as there are outer/inner hightlight and outer/inner shadow.
>> Updated spec to clarify the same.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   javadoc change

src/java.desktop/share/classes/javax/swing/border/BevelBorder.java line 94:

> 92:      * bevel outer shadow color
> 93:      * and bevel inner shadow color
> 94:      * will be derived from specified shadow color.

It mostly looks fine, but probably we may reformat it better than 55 chars per line.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3305


More information about the swing-dev mailing list