<Swing Dev> RFR: 8182043: Access to Windows Large Icons [v3]

[Alexey Ivanov]

On Wed, 10 Mar 2021 20:40:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp
>>   
>>   Select one icon at a time.
>>   
>>   Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>
> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 64:
> 
>> 62:             }
>> 63: 
>> 64:             if (icon.getIconWidth() != size) {
> 
> Does it make sense to check that the icon is a multi-resolution image with the expected sizes?
> We know for sure `explorer.exe` contains the entire set of icons.

Since the test always expects a multi-resolution image, does it make sense to assert `icon instanceof MultiResolutionImage` at the very least?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2875