<Swing Dev> RFR: 5015261: JInternalFrame causes NPE [v2]
Sergey Bylokhov
serb at openjdk.java.net
Thu Aug 12 02:23:30 UTC 2021
On Mon, 9 Aug 2021 04:21:08 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> JInternalFrame.getDesktopIcon() can be null as setDesktopIcon() can be called with null value. There are many places in JInternalFrame where getDesktopIcon() is accessed without null check which might cause NPE.
>> Added null check for those cases.
>
> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>
> - Remove test
> - Update javadoc clarification
src/java.desktop/share/classes/javax/swing/JInternalFrame.java line 1308:
> 1306: * Sets the <code>JDesktopIcon</code> associated with this
> 1307: * <code>JInternalFrame</code>.
> 1308: * Setting <code>null</code> icon is unsupported and may throw NPE if used.
The field itself is protected and can be changed by the user.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4989
More information about the swing-dev
mailing list