<Swing Dev> RFR: 5015261: JInternalFrame causes NPE [v2]

[Prasanta Sadhukhan]

On Thu, 12 Aug 2021 02:20:51 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove test
>>  - Update javadoc clarification
>
> src/java.desktop/share/classes/javax/swing/JInternalFrame.java line 1308:
> 
>> 1306:      * Sets the <code>JDesktopIcon</code> associated with this
>> 1307:      * <code>JInternalFrame</code>.
>> 1308:      * Setting <code>null</code> icon is unsupported and may throw NPE if used.
> 
> The field itself is protected and can be changed by the user.

I guess that is why we are putting up this statement, no so that user thinks twice before making it null? Should we make the field private?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4989