<Swing Dev> RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."
Prasanta Sadhukhan
psadhukhan at openjdk.java.net
Mon Aug 16 10:04:32 UTC 2021
On Wed, 11 Aug 2021 09:03:57 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> The test fails in CI testing citing expected "rededited" but found "redEDITED", which seems to point to fact that either there is a CAPS_LOCK key switched on or some other test did not use SHIFT key corectly ie, pressed but not released.
>
> Considering many more tests would have failed if CAPS_LOCK is turned on, I tried to find if some tests uses SHIFT key mistakenly and it seems JRadioButton test has press/release order wrong and it uses SHIFT. Rectified that.
>
> In addition, corrected some known CI issues ie waiting after frame is made visible, made frame to centre. Along with that, also modified testcase to check lowercase string. Since the original JDK-4275046 issue is about newly entered text is made part of cell or not, it does not matter if it's in lowercase/uppercase and if such CAPS_LOCK or Shift key problem happens again, this test will not be affected.
>
> CI run for several iterations running these 2 tests one after another in all platforms is green.
There was one fix done way back regarding almost same tests being failed due to CAPS_LOCK not turned off by test
https://github.com/openjdk/jdk/commit/51837b8a13d24279b8f9a1e36dee7320901a9cc9
but I could not find any other test doing something similar with setLockingState...
One was in java/awt/Toolkit/Headless/HeadlessToolkit.java but it is marked headless so would not affect headful test so I was thinking it's more of VK_SHIFT issue
-------------
PR: https://git.openjdk.java.net/jdk/pull/5079
More information about the swing-dev
mailing list