<Swing Dev> RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'." [v2]

[Phil Race]

On Mon, 16 Aug 2021 13:45:49 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> The test fails in CI testing citing expected "rededited" but found "redEDITED", which seems to point to fact that either there is a CAPS_LOCK key switched on or some other test did not use SHIFT key corectly  ie, pressed but not released.
>> 
>> Considering many more tests would have failed if CAPS_LOCK is turned on, I tried to find if some tests uses SHIFT key mistakenly and it seems JRadioButton test has press/release order wrong and it uses SHIFT. Rectified that.
>> 
>> In addition, corrected some known CI issues ie waiting after frame is made visible, made frame to centre. Along with that, also modified testcase to check lowercase string. Since the original JDK-4275046 issue is about newly entered text is made part of cell or not, it does not matter if it's in lowercase/uppercase and if such CAPS_LOCK or Shift key problem happens again, this test will not be affected.
>> 
>> CI run for several iterations running these 2 tests one after another in all platforms is green.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Testfix for inadvertent CAPS_LOCK enable problem

test/jdk/javax/swing/JTable/4275046/bug4275046.java line 180:

> 178:             // Read the edited value of from the cell
> 179:             editedValue = table.getModel().getValueAt(0, 1);
> 180:             editedValue = ((String)editedValue).toLowerCase();

So this just masks that some other test is the real problem.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5079