<Swing Dev> RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'." [v3]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Tue Aug 17 05:37:47 UTC 2021


> The test fails in CI testing citing expected "rededited" but found "redEDITED", which seems to point to fact that either there is a CAPS_LOCK key switched on or some other test did not use SHIFT key corectly  ie, pressed but not released.
> 
> Considering many more tests would have failed if CAPS_LOCK is turned on, I tried to find if some tests uses SHIFT key mistakenly and it seems JRadioButton test has press/release order wrong and it uses SHIFT. Rectified that.
> 
> In addition, corrected some known CI issues ie waiting after frame is made visible, made frame to centre. Along with that, also modified testcase to check lowercase string. Since the original JDK-4275046 issue is about newly entered text is made part of cell or not, it does not matter if it's in lowercase/uppercase and if such CAPS_LOCK or Shift key problem happens again, this test will not be affected.
> 
> CI run for several iterations running these 2 tests one after another in all platforms is green.

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  VK_SHIFT test anomaly fix

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5079/files
  - new: https://git.openjdk.java.net/jdk/pull/5079/files/dd910c58..1de7e162

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5079&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5079&range=01-02

  Stats: 14 lines in 2 files changed: 8 ins; 6 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5079.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5079/head:pull/5079

PR: https://git.openjdk.java.net/jdk/pull/5079


More information about the swing-dev mailing list