<Swing Dev> RFR: 5015261: JInternalFrame causes NPE [v5]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Thu Aug 19 16:48:46 UTC 2021


> JInternalFrame.getDesktopIcon() can be null as setDesktopIcon() can be called with null value. There are many places in JInternalFrame where getDesktopIcon() is accessed without null check which might cause NPE. 
> Added null check for those cases.

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Throw NPE upfront in setter

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4989/files
  - new: https://git.openjdk.java.net/jdk/pull/4989/files/3e1a444d..1351b93c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4989&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4989&range=03-04

  Stats: 8 lines in 1 file changed: 4 ins; 2 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4989.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4989/head:pull/4989

PR: https://git.openjdk.java.net/jdk/pull/4989


More information about the swing-dev mailing list