<Swing Dev> RFR: 5015261: NPE may be thrown if JDesktopIcon is set to null on a JInternalFrame [v6]

[Phil Race]

On Mon, 23 Aug 2021 03:58:49 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> JInternalFrame.getDesktopIcon() can be null as setDesktopIcon() can be called with null value. There are many places in JInternalFrame where getDesktopIcon() is accessed without null check which might cause NPE. 
>> Added null check for those cases.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Field spec wording corrected

Marked as reviewed by prr (Reviewer).

src/java.desktop/share/classes/javax/swing/JInternalFrame.java line 192:

> 190:      * The icon that is displayed when this internal frame is iconified.
> 191:      * Subclassers must ensure this is set to a non-null value
> 192:      * during construction and nor subsequently set this to null.

nor->not (looks like a typo I made in the CSR) as r and t keys are adjacent. I fixed the CSR but you'll have to to fix it here, otherwise seems fine

-------------

PR: https://git.openjdk.java.net/jdk/pull/4989