<Swing Dev> RFR: 8272148: JDesktopPane:getComponentCount() returns one extra than expected with GTKLookAndFeel [v2]
Pankaj Bansal
pbansal at openjdk.java.net
Wed Aug 25 10:39:43 UTC 2021
On Mon, 23 Aug 2021 17:01:46 GMT, Phil Race <prr at openjdk.org> wrote:
>> Pankaj Bansal has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review Comments
>
> src/java.desktop/share/classes/javax/swing/JComponent.java line 188:
>
>> 186: * change according to look and feel, as some look and feels may add a
>> 187: * default component to a container, where as other look and feels may
>> 188: * choose not to do so.
>
> "a" is not "any number" so you need to make your wording consistent.
> Also I think you need to say that even for a specific L&F it may vary depending on configuration properties of the
> JComponent.
>
> And perhaps finish with
> "In summary, it is not valid to assume a JComponent has no children just because the application did not directly add them" ?
Done
-------------
PR: https://git.openjdk.java.net/jdk/pull/5121
More information about the swing-dev
mailing list