<Swing Dev> RFR: 8197825: [Test] Intermittent timeout with javax/swing JColorChooser Test [v4]

[Sergey Bylokhov]

On Mon, 1 Feb 2021 03:52:54 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>>> > Does this volatile modifier resolve the now-removed infinite loop in `while (!tk.IsDisposed())` in `WToolkit_shutdown`?
>>> 
>>> The loop should not be removed.
>> 
>> No, it should not, as you noted previously.
>> 
>> However, making `m_breakMessageLoop` volatile does not look right either. If `QuitMessageLoop` is called from `!IsMainThread()` thread, it is posted as a message to run on the correct thread. Thus `m_breakMessageLoop` should be accessed on a single thread only; if it's the case, volatile is unneeded.
>> 
>> And @prsadhuk's latest test confirms it. There must be something else…
>
> I ran the test locally for several iterations but it does not fail locally so I believe it's a test issue. Re reverting the test changes made in 1st webrev...

I do not see a reason to change the test until the root cause of the hang is not recognized.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2220