<Swing Dev> RFR: JDK-8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test [v4]

[Alexey Ivanov]

On Wed, 6 Jan 2021 09:46:10 GMT, K Suman Rajkumaar <github.com+70650887+skodanda at openjdk.org> wrote:

>> Hi All, Could you please review this fix for JDK16?
>> 
>> Problem Description: The test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based.
>> 
>> Fix: Rewritten the above applet based test to a regular java test.
>> 
>> Best Regards,
>> K Suman Rajkumaar
>
> K Suman Rajkumaar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Deleted the bug8031573.html

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java line 120:

> 118:             }
> 119:         });
> 120:         frame.setSize(760, 250);

Doesn't `pack()` work?

test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java line 121:

> 119:         });
> 120:         frame.setSize(760, 250);
> 121:         frame.setLocation(0, 250);

Shall the frame rather be centred on the screen by using `setLocationRelativeTo(null)`?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1878