<Swing Dev> Integrated: 8048109: JToggleButton does not fire actionPerformed under certain conditions
Tejpal Rebari
trebari at openjdk.java.net
Sun Jan 10 12:42:02 UTC 2021
On Mon, 12 Oct 2020 08:01:43 GMT, Tejpal Rebari <trebari at openjdk.org> wrote:
> Please review the following fix for jdk16.
>
> Issue : There is a JToggleButton that will post/take down a JPopupMenu when the button is selected. If the button is selected and the menu is not posted the action listener will post the menu. If the button is selected and the menu is displayed the action listener will take the menu down. The use case is:
> 1 - select button
> 2 - menu posted
> 3 - select button
> 4 - menu taken down
>
> With MetalLookAndFeel the above use case works fine, but with WindowsLookAndFeel the second button selection does not fire the actionPerformed event, button needs to be selected third time for the menu to be taken down.
>
> The issue is that the button must be selected twice after the menu is posted to have the actionPerformed event to fire when using the Windows look and feel.
>
> Fix : MouseGrabber is not removed while uninstalling the listeners in the BasicPopupMenuUI.
> By removing the mouseGrabber in the uninstallListeners() methods fixes this issue.
>
> Added a test to test the same in all the LookAndFeels
This pull request has now been integrated.
Changeset: 65ca5c66
Author: Tejpal Rebari <trebari at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/65ca5c66
Stats: 169 lines in 5 files changed: 165 ins; 0 del; 4 mod
8048109: JToggleButton does not fire actionPerformed under certain conditions
Reviewed-by: serb, psadhukhan, vdyakov
-------------
PR: https://git.openjdk.java.net/jdk/pull/600
More information about the swing-dev
mailing list