<Swing Dev> RFR: 8257664: HTMLEditorKit: Wrong CSS relative font sizes [v5]

Mon Jan 18 12:14:47 UTC 2021

On Sat, 16 Jan 2021 06:45:35 GMT, Stanimir Stamenkov <github.com+1247730+stanio at openjdk.org> wrote:

>> Fix for [JDK-8257664][] – HTMLEditorKit: Wrong CSS relative font sizes.
>> 
>> _Disclaimer:_ I'm the reporter of the issue and I've been advised the best chance to get it addressed is to submit a pull request against this repository.  I haven't built the JDK myself, I'll need guidance if required.  I have a proof-of-concept example – demonstrating the bug and a workaround available as a [public gist](https://gist.github.com/stanio/b79ce9348946aa6b3395328ec4c59d14).  I have included a sample test though I don't know if it is annotated properly.
>> 
>> **Current behavior**
>> 
>> <style>
>>   h2, .h2 { font-size: 150% }
>> </style>
>> 
>> <body>
>> 
>>   <h2>Foo</h2>            
>> 
>>   <div class=h2>Bar</div> 
>> 
>>   <ol class=h2>           
>>     <li>Baz</li>          
>>   </ol>
>> 
>>   <table class=h2>
>>     <tr>
>>       <td>Qux</td>        
>>     </tr>
>>   </table>
>> 
>> </body>
>> 
>> **Expected behavior**
>> 
>> All text should be displayed with a font size of the computed `<body>` font-size × 1.5.
>> 
>> [JDK-8257664]: https://bugs.openjdk.java.net/browse/JDK-8257664
>
> Stanimir Stamenkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixup! 8257664: Fix font-size inheritance with percentage values
>   
>   Declare fontSizeInherit() accessor private.

Looks good to me. Internal testing is also ok. 
However, I have one question, html text is honouring "font-size" value(say 1.5 as per testcase) but if Display resolution in windows system setting or via -Dsun.java2d.uiScale is set to something different(say 1.25), then should it honour the font-size property (1.5) or Display resolution (1.25)?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1759