<Swing Dev> RFR: 8257664: HTMLEditorKit: Wrong CSS relative font sizes [v5]
Stanimir Stamenkov
github.com+1247730+stanio at openjdk.java.net
Mon Jan 18 13:23:50 UTC 2021
On Mon, 18 Jan 2021 12:23:27 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Stanimir Stamenkov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fixup! 8257664: Fix font-size inheritance with percentage values
>>
>> Declare fontSizeInherit() accessor private.
>
> Looks good to me.
The display dpi shouldn't matter. I've tried it in a couple of different monitor configurations: 1.25, 1.5, and 2.0 scaling. I've also tried it with non-dpi-aware Java 8. I've used `body { font-size: 14 }` which should always evaluate to `Font.size=14` (no matter the `w3cLengthUnits` value, for example) – the other elements use relative to that base font-size.
Before I type `/integrate`, is the rebase smart enough to squash the _fixup!_ commits, or should I rebase manually once for that purpose? Maybe it would squash the commits in any case? @aivanov-jdk or @prsadhuk, would you sponsor this PR?
-------------
PR: https://git.openjdk.java.net/jdk/pull/1759
More information about the swing-dev
mailing list