<Swing Dev> RFR: 8231286: HTML font size too large with high-DPI scaling and W3C_UNIT_LENGTHS

Matthias Perktold github.com+7334069+mperktold at openjdk.java.net
Tue Jan 26 15:58:48 UTC 2021


On Tue, 26 Jan 2021 14:36:09 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> This is what I mean, the quoted text of the CSS spec is the same for both versions.
>> 
>> Oh right I misread that, I really thought it changed, but it didn't.
>> In that case I can also leave the link as it was, should I revert that change?
>
>> > This is what I mean, the quoted text of the CSS spec is the same for both versions.
>> 
>> Oh right I misread that, I really thought it changed, but it didn't.
>> In that case I can also leave the link as it was, should I revert that change?
> 
> I believe we're talking about javadoc spec: its text has not changed.
> CSS spec is updated. Since you follow the rules of CSS 2.2, it's better to link to CSS 2.2.
> 
> So, the changes are good as they are. Do I get right, @mrserb?

> 
> 
> ⚠️ @mperktold a branch with the same name as the source branch for this pull request (`master`) is present in the [target repository](https://github.com/openjdk/jdk). If you eventually integrate this pull request then the branch `master` in your [personal fork](https://github.com/mperktold/jdk) will diverge once you sync your personal fork with the upstream repository.
> 
> To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. [...]

I am not sure whether I should still do this or not, since there is already some feedback, and I don't know what happens to that.
In particular, I didn't understand if this is just a suggestion or actually required.

@aivanov-jdk if it's not required, do you have any preferences?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2223


More information about the swing-dev mailing list