<Swing Dev> RFR: 8231286: HTML font size too large with high-DPI scaling and W3C_UNIT_LENGTHS

[Prasanta Sadhukhan]

On Tue, 26 Jan 2021 17:34:04 GMT, Matthias Perktold <github.com+7334069+mperktold at openjdk.org> wrote:

>>> > ⚠️ @mperktold a branch with the same name as the source branch for this pull request (`master`) is present in the [target repository](https://github.com/openjdk/jdk). If you eventually integrate this pull request then the branch `master` in your [personal fork](https://github.com/mperktold/jdk) will diverge once you sync your personal fork with the upstream repository.
>>> > To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. [...]
>>> 
>>> I am not sure whether I should still do this or not, since there is already some feedback, and I don't know what happens to that.
>>> In particular, I didn't understand if this is just a suggestion or actually required.
>>> 
>>> @aivanov-jdk if it's not required, do you have any preferences?
>> 
>> I see you opened the PR from master branch in your personal fork rather than a new branch.
>> 
>> Yes, I think you should go on as suggested: create a new PR from a new branch.
>> 
>> You can create the new PR with comments addressed and link to the old PR in the description.
>> 
>> In addition to that, if I get it right, you, @mperktold, have taken over this issue from @prsadhuk, thus #1628 is superseded by this PR and should be closed without integration. Eventually, this PR will be superseded by a new PR that you'll create.
>> 
>> Can you edit the subject of the JBS issue to amend the constant `W3C_LENGTH_UNITS`?
>
>> I see you opened the PR from master branch in your personal fork rather than a new branch.
>> 
>> Yes, I think you should go on as suggested: create a new PR from a new branch.
> 
> OK, will do. If you don't mind, I have a couple of noob questions, as I'm new to the whole process:
> 
>> You can create the new PR with comments addressed and link to the old PR in the description.
> 
> Is there anything special I need to do to have "comments addressed"? Should I first apply your patches, and then proceed with the new fork afterwards?
> 
>> Can you edit the subject of the JBS issue to amend the constant W3C_LENGTH_UNITS?
> 
> I don't think I have the rights to do this. I don't even have an JBS account, I submitted the bug through the https://bugs.java.com/bugdatabase/. I just recently signed the OCA, is that sufficient to create a JBS account?

@mperktold I guess this PR needs to be closed since this is from master branch. Please create a new PR from your fix branch with this latest changeset. The review will continue on top of that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2223