<Swing Dev> RFR: 8197825: [Test] Intermiitent timeout with javax/swing JColorChooser Test [v2]

Sergey Bylokhov serb at openjdk.java.net
Thu Jan 28 00:43:42 UTC 2021


On Wed, 27 Jan 2021 12:35:38 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Prevent infinite loop
>
> src/java.desktop/windows/native/libawt/windows/awt_Toolkit.cpp line 2611:
> 
>> 2609:         Sleep(100);
>> 2610:     }
>> 2611: 
> 
> It can cause infinite looping as the message queue to get DISPOSE events is removed so if we are not getting disposed by now, we probably will not get DISPOSE event ever causing infinite loop.
> XToolkit, LWToolkit does not have this infinite loop.

My point is that this is not a test bug, so the test should not be changed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2220


More information about the swing-dev mailing list