<Swing Dev> RFR: 8197825: [Test] Intermiitent timeout with javax/swing JColorChooser Test [v3]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Fri Jan 29 04:06:47 UTC 2021


On Thu, 28 Jan 2021 19:50:56 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>>> 
>>> My point is that this is not a test bug, so the test should not be changed.
>> 
>> The test never dispose of the frame. Why is it expected to shut down the toolkit? Shall the frame be disposed of when the main thread in the test finishes?
>
>> The test never dispose of the frame. Why is it expected to shut down the toolkit? Shall the frame be disposed of when the main thread in the test finishes?
> 
> The shutdown is caused by the System.exit call while the toolkit active, so we should shut down it before the end.

It seems "m_breakMessageLoop" is never true for unsuccessful run even though AwtToolkit::QuitMessageLoop finish execution (where m_breakMessageLoop is set to true),
so AwtToolkit::MessageLoop never ends, seems to be some timing issue.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2220


More information about the swing-dev mailing list