<Swing Dev> [jdk17] RFR: 8269269: [macos11] SystemIconTest fails with ClassCastException [v2]

Thu Jul 1 16:24:00 UTC 2021

On Wed, 30 Jun 2021 20:11:53 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> I am a bit surprised the tests for this are not already headful. I can imagine all sorts of platform reasons why making them headless is not testing the "real" use case making the tests less than useful.
>> Ever seen a hidpi  headless system ??
>
>> I am a bit surprised the tests for this are not already headful
> 
> Fixed.

That test was not marked as headful because this API should work in the headless environment as well, if it does not work when we have a bug in the shell classes which should return the icon from the UIManager on any error. I think it worked as expected.

As far as I understand when we cannot access the image of some specific file we tried to get a generic image via shell32.dll, does it fail as well? Is it possible that when we try to create the failback icon here:
https://github.com/openjdk/jdk/blob/82bfc5d45c54fb37dc021bc91fa17efe34f77f44/src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java#L1199
we get the icon of the correct size and skip the creation of "MultiResolutionIconImage"? As a result, the test fails because the icon is not multi-resolution.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/178