<Swing Dev> RFR: 8270058: Use Objects.check{Index, FromIndexSize} for java.desktop [v3]

Pankaj Bansal pbansal at openjdk.java.net
Fri Jul 30 08:44:31 UTC 2021


On Fri, 30 Jul 2021 08:17:29 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   typo
>
> src/java.desktop/share/classes/javax/swing/JTabbedPane.java line 1793:
> 
>> 1791: 
>> 1792:     private void checkIndex(int index) {
>> 1793:         Objects.checkIndex(index, pages.size());
> 
> I think we should not replace IOOBE checks with messages. Its better to keep it old way.

Objects.checkIndex itself throws exceptions for wrong values. So this should be ok. No?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4718


More information about the swing-dev mailing list